nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [incubator-nemo] hy00nc commented on a change in pull request #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer)
Date Wed, 24 Jul 2019 07:15:57 GMT
hy00nc commented on a change in pull request #223: [NEMO-388] Off-heap memory management (reuse

 File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/
 @@ -0,0 +1,42 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+ * An exception to be thrown when a memory allocation operation is not successful.
+ */
+public class MemoryAllocationException extends Exception {
 Review comment:
   I also noticed that this exception is never thrown in this PR. I suppose it will be used
in the upcoming implementation, regarding the off-heap region separation (thrown when the
off-heap memory allocation exceeds the region specification). I will add the description to
this exception and remove the unnecessary `catch` clauses. 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message