From notifications-return-632-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Mon Jun 24 05:40:38 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B5438180671 for ; Mon, 24 Jun 2019 07:40:37 +0200 (CEST) Received: (qmail 37968 invoked by uid 500); 24 Jun 2019 05:40:37 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 37959 invoked by uid 99); 24 Jun 2019 05:40:37 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jun 2019 05:40:37 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] hy00nc commented on a change in pull request #219: [NEMO-351] Empowering Nemo with fast I/O using Apache Crail Message-ID: <156135483705.8182.3148014289763933856.gitbox@gitbox.apache.org> Date: Mon, 24 Jun 2019 05:40:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hy00nc commented on a change in pull request #219: [NEMO-351] Empowering Nemo with fast I/O using Apache Crail URL: https://github.com/apache/incubator-nemo/pull/219#discussion_r296558238 ########## File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/stores/RemoteFileStore.java ########## @@ -21,8 +21,9 @@ import org.apache.reef.tang.annotations.DefaultImplementation; /** - * Interface for remote block stores (e.g., GlusterFS, ...). + * Interface for remote block stores (e.g., GlusterFS, CrailFS...). */ + @DefaultImplementation(GlusterFileStore.class) Review comment: Actually `RemoteFileStore` is constructed by default in every job, and using Crail as the default would cause every job to fail when there is no CrailFileSystem detected on the nodes that run the job. So maybe `GlusterFileStore` can be the default? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services