From notifications-return-571-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Fri Jun 14 07:28:13 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EFE7918062F for ; Fri, 14 Jun 2019 09:28:12 +0200 (CEST) Received: (qmail 56425 invoked by uid 500); 14 Jun 2019 07:28:12 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 56416 invoked by uid 99); 14 Jun 2019 07:28:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jun 2019 07:28:12 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] wynot12 commented on a change in pull request #220: [NEMO-395] Address SonarCloud issues for the scheduler package Message-ID: <156049728736.13218.14580542118522995756.gitbox@gitbox.apache.org> Date: Fri, 14 Jun 2019 07:28:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit wynot12 commented on a change in pull request #220: [NEMO-395] Address SonarCloud issues for the scheduler package URL: https://github.com/apache/incubator-nemo/pull/220#discussion_r293684848 ########## File path: runtime/master/src/main/java/org/apache/nemo/runtime/master/scheduler/TaskDispatcher.java ########## @@ -205,7 +205,7 @@ void signal() { void await() { lock.lock(); try { - if (!hasDelayedSignal) { + while (!hasDelayedSignal) { Review comment: How about to add a simple comment that this while loop is to deal with spurious wakeup? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services