From notifications-return-553-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Tue Jun 11 03:09:17 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 32D25180789 for ; Tue, 11 Jun 2019 05:09:16 +0200 (CEST) Received: (qmail 51799 invoked by uid 500); 11 Jun 2019 03:08:58 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 51602 invoked by uid 99); 11 Jun 2019 03:08:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jun 2019 03:08:58 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] johnyangk commented on a change in pull request #219: [NEMO-351] Empowering Nemo with fast I/O using Apache Crail Message-ID: <156022253778.28046.3319910213590975117.gitbox@gitbox.apache.org> Date: Tue, 11 Jun 2019 03:08:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit johnyangk commented on a change in pull request #219: [NEMO-351] Empowering Nemo with fast I/O using Apache Crail URL: https://github.com/apache/incubator-nemo/pull/219#discussion_r292261540 ########## File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/metadata/CrailFileMetadata.java ########## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.nemo.runtime.executor.data.metadata; + +import org.apache.commons.lang3.SerializationUtils; +import org.apache.crail.*; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.annotation.concurrent.ThreadSafe; +import java.io.*; +import java.util.ArrayList; +import java.util.List; + +/** + * This class represents a metadata for a file block in CrailFileSystem. + * Because the data is stored in a CrailFileSystem and globally accessed by multiple nodes, + * each read, or deletion for a block needs one instance of this metadata. + * The metadata is stored in and read from a CrailFile (after a CrailFile block is committed). + * @param the key type of its partitions. + */ +@ThreadSafe +public final class CrailFileMetadata extends FileMetadata { Review comment: Again, I see similarities with RemoteFileMetadata. Can you reuse code? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services