nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] hy00nc commented on a change in pull request #222: [NEMO-350] Implement Off-heap SerializedMemoryStore & [NEMO-384] Implement DirectByteBufferInputStream for Off-heap SerializedMemoryStore
Date Fri, 21 Jun 2019 03:44:43 GMT
hy00nc commented on a change in pull request #222: [NEMO-350] Implement Off-heap SerializedMemoryStore
& [NEMO-384] Implement DirectByteBufferInputStream for Off-heap SerializedMemoryStore
URL: https://github.com/apache/incubator-nemo/pull/222#discussion_r296086535
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/DirectByteBufferInputStream.java
 ##########
 @@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.common;
+
+import java.io.EOFException;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.ByteBuffer;
+import java.util.List;
+
+/**
+ * This class is a customized input stream implementation which reads data from
+ * list of {@link ByteBuffer}.
+ */
+public class DirectByteBufferInputStream extends InputStream {
+  private List<ByteBuffer> bufList;
 
 Review comment:
   I think you're right, the name of the class implies that this is only for `DirectByteBuffer`.
I guess it is better to change the name of the class to `ByteBufferInputStream` because `DirectByteBuffer`
class is not public and it can only be constructed by calling `allocateDirect()` method in
`ByteBuffer`. It is possible to check whether the `ByteBuffer` is direct or not, but I am
afraid it has no much meaning in checking it when it is already written(in on-heap or off-heap)
and we are intending to **read** it. I will change the name to make it more straightforward
and be used to read the on-heap `ByteBuffer` in future implementation. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message