nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] johnyangk commented on a change in pull request #222: [NEMO-350] Implement Off-heap SerializedMemoryStore & [NEMO-384] Implement DirectByteBufferInputStream for Off-heap SerializedMemoryStore
Date Wed, 19 Jun 2019 07:22:55 GMT
johnyangk commented on a change in pull request #222: [NEMO-350] Implement Off-heap SerializedMemoryStore
& [NEMO-384] Implement DirectByteBufferInputStream for Off-heap SerializedMemoryStore
URL: https://github.com/apache/incubator-nemo/pull/222#discussion_r295137839
 
 

 ##########
 File path: examples/beam/pom.xml
 ##########
 @@ -41,7 +41,6 @@ under the License.
       <groupId>org.apache.nemo</groupId>
       <artifactId>nemo-client</artifactId>
       <version>${project.version}</version>
-      <scope>test</scope>
 
 Review comment:
   Please keep this scope.
   examples/beam should not depend on nemo-client. We want to remove L40-L44 eventually.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message