nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] johnyangk commented on a change in pull request #220: [NEMO-395] Address SonarCloud issues for the scheduler package
Date Fri, 14 Jun 2019 07:33:43 GMT
johnyangk commented on a change in pull request #220: [NEMO-395] Address SonarCloud issues
for the scheduler package
URL: https://github.com/apache/incubator-nemo/pull/220#discussion_r293690473
 
 

 ##########
 File path: runtime/master/src/main/java/org/apache/nemo/runtime/master/scheduler/LocalitySchedulingConstraint.java
 ##########
 @@ -78,7 +78,10 @@ private LocalitySchedulingConstraint(final BlockManagerMaster blockManagerMaster
           .map(handler -> {
             try {
               return handler.getLocationFuture().get();
-            } catch (InterruptedException | ExecutionException e) {
+            } catch (ExecutionException e) {
 
 Review comment:
   I think this can be handled with a different PR. I believe most of the exceptions are non-final
at the moment.
   
   Related discussion: https://stackoverflow.com/a/3516852

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message