nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] wynot12 commented on a change in pull request #220: [NEMO-395] Address SonarCloud issues for the scheduler package
Date Fri, 14 Jun 2019 07:28:07 GMT
wynot12 commented on a change in pull request #220: [NEMO-395] Address SonarCloud issues for
the scheduler package
URL: https://github.com/apache/incubator-nemo/pull/220#discussion_r293684848
 
 

 ##########
 File path: runtime/master/src/main/java/org/apache/nemo/runtime/master/scheduler/TaskDispatcher.java
 ##########
 @@ -205,7 +205,7 @@ void signal() {
     void await() {
       lock.lock();
       try {
-        if (!hasDelayedSignal) {
+        while (!hasDelayedSignal) {
 
 Review comment:
   How about to add a simple comment that this while loop is to deal with spurious wakeup?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message