nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] johnyangk commented on a change in pull request #219: [NEMO-351] Empowering Nemo with fast I/O using Apache Crail
Date Tue, 11 Jun 2019 03:08:57 GMT
johnyangk commented on a change in pull request #219: [NEMO-351] Empowering Nemo with fast
I/O using Apache Crail
URL: https://github.com/apache/incubator-nemo/pull/219#discussion_r292261540
 
 

 ##########
 File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/metadata/CrailFileMetadata.java
 ##########
 @@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.runtime.executor.data.metadata;
+
+import org.apache.commons.lang3.SerializationUtils;
+import org.apache.crail.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.concurrent.ThreadSafe;
+import java.io.*;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * This class represents a metadata for a file block in CrailFileSystem.
+ * Because the data is stored in a CrailFileSystem and globally accessed by multiple nodes,
+ * each read, or deletion for a block needs one instance of this metadata.
+ * The metadata is stored in and read from a CrailFile (after a CrailFile block is committed).
+ * @param <K> the key type of its partitions.
+ */
+@ThreadSafe
+public final class CrailFileMetadata<K extends Serializable> extends FileMetadata<K>
{
 
 Review comment:
   Again, I see similarities with RemoteFileMetadata.
   Can you reuse code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message