From notifications-return-503-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Fri Apr 26 15:57:44 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D5E1718077A for ; Fri, 26 Apr 2019 17:57:43 +0200 (CEST) Received: (qmail 18262 invoked by uid 500); 26 Apr 2019 15:57:43 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 18235 invoked by uid 99); 26 Apr 2019 15:57:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Apr 2019 15:57:43 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] wynot12 commented on a change in pull request #215: [NEMO-373] Optimize with DAG Patterns Message-ID: <155629426323.4386.9325572301727777287.gitbox@gitbox.apache.org> Date: Fri, 26 Apr 2019 15:57:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit wynot12 commented on a change in pull request #215: [NEMO-373] Optimize with DAG Patterns URL: https://github.com/apache/incubator-nemo/pull/215#discussion_r278994235 ########## File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/OptimizerUtils.java ########## @@ -36,28 +46,72 @@ private OptimizerUtils() { } /** - * Restore the formatted string into a pair of vertex/edge id and the execution property. + * Restore the formatted string into a pair of vertex/edge list and the execution property. * * @param string the formatted string. - * @return a pair of vertex/edge id and the execution property key index. + * @param dag the IR DAG to observe. + * @return a pair of vertex/edge list and the execution property key index. */ - public static Pair stringToIdAndEPKeyIndex(final String string) { - // Formatted into 9 digits: 0:vertex/edge 1-5:ID 5-9:EP Index. + public static Pair, Integer> stringToObjAndEPKeyIndex(final String string, final IRDAG dag) { Review comment: How about to change it to 'Obj**s**AndEPKeyIndex'? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services