From notifications-return-495-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Wed Apr 17 10:31:56 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 69386180672 for ; Wed, 17 Apr 2019 12:31:56 +0200 (CEST) Received: (qmail 45185 invoked by uid 500); 17 Apr 2019 10:31:55 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 45175 invoked by uid 99); 17 Apr 2019 10:31:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Apr 2019 10:31:55 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] taegeonum commented on a change in pull request #214: [NEMO-385]LambdaPass, LambdaPolicy and ResourceLambdaProperty Message-ID: <155549711057.8198.4413731881338385537.gitbox@gitbox.apache.org> Date: Wed, 17 Apr 2019 10:31:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit taegeonum commented on a change in pull request #214: [NEMO-385]LambdaPass, LambdaPolicy and ResourceLambdaProperty URL: https://github.com/apache/incubator-nemo/pull/214#discussion_r276176899 ########## File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ResourceLambdaProperty.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.nemo.common.ir.vertex.executionproperty; + +import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty; + +/** + * Maintainer: Gao Zhiyuan. + * Resource property supporting Lambda Pass + */ +public final class ResourceLambdaProperty extends VertexExecutionProperty { Review comment: why don't you add a `LAMBDA` variable in `ResourcePriorityProperty` class? we don't need to create another class for the resource lambda property. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services