From notifications-return-454-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Sun Apr 14 06:28:53 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ED28D180638 for ; Sun, 14 Apr 2019 08:28:52 +0200 (CEST) Received: (qmail 12480 invoked by uid 500); 14 Apr 2019 06:28:52 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 12470 invoked by uid 99); 14 Apr 2019 06:28:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Apr 2019 06:28:52 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] DifferentSC commented on a change in pull request #213: [NEMO-383] Implement DirectByteBufferOutputStream for Off-heap SerializedMemoryStore Message-ID: <155522333221.16347.5974466510529779793.gitbox@gitbox.apache.org> Date: Sun, 14 Apr 2019 06:28:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit DifferentSC commented on a change in pull request #213: [NEMO-383] Implement DirectByteBufferOutputStream for Off-heap SerializedMemoryStore URL: https://github.com/apache/incubator-nemo/pull/213#discussion_r275142296 ########## File path: common/src/main/java/org/apache/nemo/common/DirectByteBufferOutputStream.java ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.nemo.common; + +import java.io.OutputStream; +import java.nio.ByteBuffer; +import java.util.LinkedList; + +/** + * This class is a customized output stream implementation backed by + * {@link ByteBuffer}, which utilizes off heap memory when writing the data. + * Memory is allocated when needed by the specified {@code pageSize}. + */ +public class DirectByteBufferOutputStream extends OutputStream { + + private final LinkedList dataList = new LinkedList<>(); + private final int pageSize; + + /** + * Default constructor. + * Sets the {@code pageSize} as default size of 4KB. + */ + public DirectByteBufferOutputStream() { + pageSize = 4096; + } + + /** + * Constructor specifying the {@code pageSize}. + * + * @param size should be a power of 2 and greater than 4KB. Review comment: +1 for from 4KB to 4096 bytes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services