nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] hy00nc commented on issue #213: [NEMO-383] Implement DirectByteBufferOutputStream for Off-heap SerializedMemoryStore
Date Sun, 14 Apr 2019 10:10:17 GMT
hy00nc commented on issue #213: [NEMO-383] Implement DirectByteBufferOutputStream for Off-heap
SerializedMemoryStore
URL: https://github.com/apache/incubator-nemo/pull/213#issuecomment-482940525
 
 
   I think creating `getByteBuffer()` is a nice idea too. I will add comments regarding the
performance issue of `toByteArray()`. And just like @taegeonum mentioned, I assume `close()`
method should do nothing for this output stream for now as long as there is a usage for `toByteArray()`.
In Nemo, I found the usage of obtaining the byte array after closing the `wrappedStream` which
includes the output stream. (though the comments say that closing the `wrappedStream` is dependent
on the property of `DirectByteArrayOutputStream`.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message