From notifications-return-415-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Thu Mar 28 10:25:19 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5D1EE18076D for ; Thu, 28 Mar 2019 11:25:19 +0100 (CET) Received: (qmail 71316 invoked by uid 500); 28 Mar 2019 10:25:13 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 71296 invoked by uid 99); 28 Mar 2019 10:25:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Mar 2019 10:25:13 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' Message-ID: <155376871288.18490.2573136471321492301.gitbox@gitbox.apache.org> Date: Thu, 28 Mar 2019 10:25:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r269932716 ########## File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/NemoOptimizer.java ########## @@ -46,19 +49,27 @@ public final class NemoOptimizer implements Optimizer { private final String dagDirectory; private final Policy optimizationPolicy; + private final String environmentTypeStr; + private final ClientRPC clientRPC; private final Map cacheIdToParallelism = new HashMap<>(); private int irDagCount = 0; /** - * @param dagDirectory to store JSON representation of intermediate DAGs. - * @param policyName the name of the optimization policy. + * @param dagDirectory to store JSON representation of intermediate DAGs. + * @param policyName the name of the optimization policy. + * @param environmentTypeStr the environment type of the workload to optimize the DAG for. + * @param clientRPC the RPC channel to communicate with the client. */ @Inject private NemoOptimizer(@Parameter(JobConf.DAGDirectory.class) final String dagDirectory, Review comment: Is this compile time or runtime optimizer? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services