From notifications-return-408-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Thu Mar 28 10:25:14 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B92BC180782 for ; Thu, 28 Mar 2019 11:25:13 +0100 (CET) Received: (qmail 70936 invoked by uid 500); 28 Mar 2019 10:25:12 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 70924 invoked by uid 99); 28 Mar 2019 10:25:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Mar 2019 10:25:12 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' Message-ID: <155376871225.18466.16590025496872691784.gitbox@gitbox.apache.org> Date: Thu, 28 Mar 2019 10:25:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r269929088 ########## File path: client/src/main/java/org/apache/nemo/client/ClientUtils.java ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.nemo.client; + +import org.apache.commons.io.FileUtils; +import org.apache.nemo.common.Util; +import org.apache.nemo.common.exception.MetricException; +import org.apache.nemo.runtime.common.comm.ControlMessage; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.File; + +/** + * Utility class for the Client. + */ +public final class ClientUtils { + private static final Logger LOG = LoggerFactory.getLogger(ClientUtils.class.getName()); + + /** + * Private constructor. + */ + private ClientUtils() { + } + + /** + * Handler for the launch optimization message. + * + * @param message the message received from the driver. + */ + static void launchOptimizationHandler(final ControlMessage.DriverToClientMessage message, + final DriverRPCServer driverRPCServer) { + switch (message.getOptimizationType()) { + case "xgboost": Review comment: It would be better to use enum instead of raw string ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services