From notifications-return-396-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Wed Mar 27 15:35:58 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6CD8318077F for ; Wed, 27 Mar 2019 16:35:57 +0100 (CET) Received: (qmail 72513 invoked by uid 500); 27 Mar 2019 15:35:56 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 72476 invoked by uid 99); 27 Mar 2019 15:35:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Mar 2019 15:35:56 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' Message-ID: <155370095602.29563.18023455079274287572.gitbox@gitbox.apache.org> Date: Wed, 27 Mar 2019 15:35:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r269608250 ########## File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/NemoOptimizer.java ########## @@ -113,6 +124,24 @@ public IRDAG optimizeAtRunTime(final IRDAG dag, final Message message) { return optimizationPolicy.runRunTimeOptimizations(dag, message); } + /** + * Operations to be done prior to the Compile-Time Optimizations. + * + * @param dag the DAG to process. + * @param policy the optimization policy to optimize the DAG with. + */ + private void beforeCompileTimeOptimization(final IRDAG dag, final Policy policy) { + if (policy instanceof XGBoostPolicy) { + clientRPC.send(ControlMessage.DriverToClientMessage.newBuilder() + .setType(ControlMessage.DriverToClientMessageType.LaunchOptimization) Review comment: Hmm.. it assumes that we already have enough metrics in DB... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services