From notifications-return-364-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Tue Mar 26 05:23:47 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7631218064C for ; Tue, 26 Mar 2019 06:23:47 +0100 (CET) Received: (qmail 25357 invoked by uid 500); 26 Mar 2019 05:23:46 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 25338 invoked by uid 99); 26 Mar 2019 05:23:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Mar 2019 05:23:46 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' Message-ID: <155357782600.11702.7789955931554650003.gitbox@gitbox.apache.org> Date: Tue, 26 Mar 2019 05:23:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r268946906 ########## File path: common/src/main/java/org/apache/nemo/common/ir/IRDAG.java ########## @@ -110,8 +109,16 @@ public boolean advanceDAGSnapshot(final BiFunction checke return canAdvance; } + /** + * @return a IR DAG summary string, consisting of only the vertices generated from the frontend. + */ public String irDAGSummary() { - return "RV" + getRootVertices().size() + "_V" + getVertices().size() + "_E" + getVertices().stream() + return "rv" + this.getRootVertices().size() + + "_v" + this.getVertices().stream() + .filter(v -> !v.isUtilityVertex()) // Exclude utility vertices + .count() + + "_e" + this.getVertices().stream() Review comment: Alright. I'll get rid of them. I thought that it improves readability, as it indicates that they are the vertices of the 'this' object. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services