From notifications-return-284-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Thu Mar 21 05:14:54 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4344618062C for ; Thu, 21 Mar 2019 06:14:54 +0100 (CET) Received: (qmail 908 invoked by uid 500); 21 Mar 2019 05:14:53 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 896 invoked by uid 99); 21 Mar 2019 05:14:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Mar 2019 05:14:53 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' Message-ID: <155314529278.21917.17638121298477282105.gitbox@gitbox.apache.org> Date: Thu, 21 Mar 2019 05:14:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267627259 ########## File path: examples/beam/src/test/java/org/apache/nemo/examples/beam/WordCountITCase.java ########## @@ -127,4 +128,14 @@ public void testSpeculativeExecution() throws Exception { .addOptimizationPolicy(AggressiveSpeculativeCloningPolicyParallelismFive.class.getCanonicalName()) .build()); } + + @Test (timeout = ExampleTestArgs.TIMEOUT) + public void testXGBoost() throws Exception { + JobLauncher.main(builder + .addResourceJson(executorResourceFileName) + .addJobId(WordCountITCase.class.getSimpleName() + "_xgboost") + .addMaxTaskAttempt(Integer.MAX_VALUE) + .addOptimizationPolicy(XGBoostPolicy.class.getCanonicalName()) + .build()); + } Review comment: What's the right output? Does it produce the same result every time? Then better to put the result as comment? It's just a suggestion. I know that all other apps of Nemo doesn't provide that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services