From notifications-return-271-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Wed Mar 20 22:45:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 03E5218078F for ; Wed, 20 Mar 2019 23:45:19 +0100 (CET) Received: (qmail 28360 invoked by uid 500); 20 Mar 2019 22:45:14 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 28280 invoked by uid 99); 20 Mar 2019 22:45:14 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Mar 2019 22:45:14 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' Message-ID: <155312191351.22045.6906215907779222752.gitbox@gitbox.apache.org> Date: Wed, 20 Mar 2019 22:45:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267571939 ########## File path: common/src/main/java/org/apache/nemo/common/ir/IRDAG.java ########## @@ -110,8 +109,16 @@ public boolean advanceDAGSnapshot(final BiFunction checke return canAdvance; } + /** + * @return a IR DAG summary string, consisting of only the original vertices generated from the frontend. Review comment: What is the original vertex? could you please define what is original or not? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services