From notifications-return-258-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Wed Mar 20 22:45:14 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D318D18077A for ; Wed, 20 Mar 2019 23:45:13 +0100 (CET) Received: (qmail 27763 invoked by uid 500); 20 Mar 2019 22:45:12 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 27752 invoked by uid 99); 20 Mar 2019 22:45:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Mar 2019 22:45:12 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' Message-ID: <155312191217.22098.14372281021445958023.gitbox@gitbox.apache.org> Date: Wed, 20 Mar 2019 22:45:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267575429 ########## File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/NemoOptimizer.java ########## @@ -54,11 +58,17 @@ /** * @param dagDirectory to store JSON representation of intermediate DAGs. * @param policyName the name of the optimization policy. + * @param environmentType the environment type of the workload to optimize the DAG for. + * @param clientRPC the RPC channel to communicate with the client. */ @Inject private NemoOptimizer(@Parameter(JobConf.DAGDirectory.class) final String dagDirectory, - @Parameter(JobConf.OptimizationPolicy.class) final String policyName) { + @Parameter(JobConf.OptimizationPolicy.class) final String policyName, + @Parameter(JobConf.EnvironmentType.class) final String environmentType, + final ClientRPC clientRPC) { this.dagDirectory = dagDirectory; + this.environmentType = environmentType; Review comment: Do we have to add environmentType? Why do we need this variable and when is it used? Actually, the environment type isn't important because the behavior depends on the optimization policy? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services