From notifications-return-231-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Wed Mar 20 11:36:42 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3B21D18077A for ; Wed, 20 Mar 2019 12:36:42 +0100 (CET) Received: (qmail 11257 invoked by uid 500); 20 Mar 2019 11:36:41 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 11240 invoked by uid 99); 20 Mar 2019 11:36:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Mar 2019 11:36:41 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' Message-ID: <155308180084.17641.17387818497048001336.gitbox@gitbox.apache.org> Date: Wed, 20 Mar 2019 11:36:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy' URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267295586 ########## File path: client/src/main/java/org/apache/nemo/client/JobLauncher.java ########## @@ -133,6 +136,11 @@ public static void setup(final String[] args) throws InjectionException, ClassNo .registerHandler(ControlMessage.DriverToClientMessageType.ExecutionDone, event -> jobDoneLatch.countDown()) .registerHandler(ControlMessage.DriverToClientMessageType.DataCollected, message -> COLLECTED_DATA.addAll( SerializationUtils.deserialize(Base64.getDecoder().decode(message.getDataCollected().getData())))) + .registerHandler(ControlMessage.DriverToClientMessageType.LaunchXGBoostScript, message -> + driverRPCServer.send(ControlMessage.ClientToDriverMessage.newBuilder() + .setType(ControlMessage.ClientToDriverMessageType.Notification) + .setMessage(MetricUtils.launchXGBoostScript(message.getDataCollected().getData())) + .build())) Review comment: I think it's a good idea. I'll try to make the change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services