From notifications-return-200-archive-asf-public=cust-asf.ponee.io@nemo.apache.org  Wed Mar 20 09:23:46 2019
Return-Path: <notifications-return-200-archive-asf-public=cust-asf.ponee.io@nemo.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 6083A180791
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 20 Mar 2019 10:23:46 +0100 (CET)
Received: (qmail 93450 invoked by uid 500); 20 Mar 2019 09:23:45 -0000
Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@nemo.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@nemo.apache.org>
List-Post: <mailto:notifications@nemo.apache.org>
List-Id: <notifications.nemo.apache.org>
Reply-To: dev@nemo.apache.org
Delivered-To: mailing list notifications@nemo.apache.org
Received: (qmail 93419 invoked by uid 99); 20 Mar 2019 09:23:45 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Mar 2019 09:23:45 +0000
From: GitBox <git@apache.org>
To: notifications@nemo.apache.org
Subject: [GitHub] [incubator-nemo] wynot12 commented on a change in pull request
 #203: [NEMO-360] Implementing an 'XGBoostPolicy'
Message-ID: <155307382492.31010.3387374487644501081.gitbox@gitbox.apache.org>
Date: Wed, 20 Mar 2019 09:23:44 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267227868
 
 

 ##########
 File path: runtime/common/src/main/proto/ControlMessage.proto
 ##########
 @@ -23,37 +23,43 @@ package protobuf;
 option java_package = "org.apache.nemo.runtime.common.comm";
 option java_outer_classname = "ControlMessage";
 
+// Messages from client to driver
 enum ClientToDriverMessageType {
     LaunchDAG = 0;
     DriverShutdown = 1;
+    Notification = 2;
 }
 
 message ClientToDriverMessage {
     required ClientToDriverMessageType type = 1;
     optional LaunchDAGMessage launchDAG = 2;
+    optional string message = 3;
 }
 
 message LaunchDAGMessage {
     required string dag = 1;
     optional bytes broadcastVars = 2;
 }
 
-message DataCollectMessage {
-    required string data = 1;
-}
-
+// Messages from driver to client
 enum DriverToClientMessageType {
     DriverStarted = 0;
     DriverReady = 1;
     DataCollected = 2;
     ExecutionDone = 3;
+    LaunchXGBoostScript = 4;
 }
 
 message DriverToClientMessage {
     required DriverToClientMessageType type = 1;
     optional DataCollectMessage dataCollected = 2;
 }
 
+message DataCollectMessage {
+    required string data = 1;
+}
+
+
 
 Review comment:
   redundant line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services