From notifications-return-172-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Thu Mar 14 14:02:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C9E28180630 for ; Thu, 14 Mar 2019 15:02:11 +0100 (CET) Received: (qmail 61960 invoked by uid 500); 14 Mar 2019 14:02:10 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 61942 invoked by uid 99); 14 Mar 2019 14:02:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Mar 2019 14:02:10 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] alapha23 commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and waitUntilFinish methods Message-ID: <155257213036.4400.11289566597909259970.gitbox@gitbox.apache.org> Date: Thu, 14 Mar 2019 14:02:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit alapha23 commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and waitUntilFinish methods URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r265444459 ########## File path: client/src/main/java/org/apache/nemo/client/ClientEndpoint.java ########## @@ -164,7 +164,8 @@ public final Enum waitUntilJobFinish(final long timeout, return stateTranslator.translateState(driverEndpoint.get(). waitUntilFinish(timeout - unit.convert(consumedTime, TimeUnit.NANOSECONDS), unit)); } else { - return PlanState.State.READY; + // This default value needs double checking. + return stateTranslator.translateState(PlanState.State.READY); Review comment: Could you please indicate why we are changing the return type here please? As far as I could infer, `stateTranslator.translateState(PlanState.State.READY)` equals `RUNNING` defined at `PipelineResult.java`while `PlanState.State.READY` equals `READY` defined at `PlanState.java` I do not understand why we are changing here. And where is this function used please? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services