nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
Date Thu, 28 Mar 2019 10:25:12 GMT
taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r269936784
 
 

 ##########
 File path: runtime/master/src/main/java/org/apache/nemo/runtime/master/RuntimeMaster.java
 ##########
 @@ -113,13 +114,29 @@
   private final Server metricServer;
   private final MetricStore metricStore;
 
+  /**
+   * Constructor.
+   *
+   * @param scheduler                the scheduler implementation.
+   * @param containerManager         the container manager, in charge of the available containers.
+   * @param metricMessageHandler     the handler for metric messages.
+   * @param masterMessageEnvironment message environment for the runtime master.
+   * @param metricManagerMaster      metric manager master.
+   * @param clientRPC                the RPC channel to communicate with the client.
+   * @param planStateManager         the manager that keeps track of the plan state.
+   * @param jobId                    the Job ID, provided by the user.
+   * @param dbAddress                the DB Address, provided by the user.
+   * @param dbId                     the ID for the given DB.
 
 Review comment:
   Does runtime master should hold these XGBoost specific variables? Maybe it would be better
to extract these variables to other classes likeXGBoostMaster? or these variables are not
related to XGBoost? 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message