nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
Date Tue, 26 Mar 2019 05:25:34 GMT
wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r268947140
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ResourceLocalityProperty.java
 ##########
 @@ -43,7 +43,7 @@ private ResourceLocalityProperty(final boolean value) {
    * @param value value of the new execution property
    * @return the execution property
    */
-  public static ResourceLocalityProperty of(final boolean value) {
+  public static ResourceLocalityProperty of(final Boolean value) {
 
 Review comment:
   This was to keep the value types consistent, to be able to call it using reflection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message