nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
Date Tue, 26 Mar 2019 05:24:30 GMT
wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r268947002
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/IgnoreSchedulingTempDataReceiverProperty.java
 ##########
 @@ -32,13 +32,13 @@
 public final class IgnoreSchedulingTempDataReceiverProperty extends VertexExecutionProperty<Boolean>
{
 
   private static final IgnoreSchedulingTempDataReceiverProperty IGNORE_SCHEDULING_TEMP_DATA_RECEIVER_PROPERTY
=
-    new IgnoreSchedulingTempDataReceiverProperty();
+    new IgnoreSchedulingTempDataReceiverProperty(true);
 
   /**
    * Constructor.
    */
-  private IgnoreSchedulingTempDataReceiverProperty() {
-    super(true);
+  private IgnoreSchedulingTempDataReceiverProperty(final Boolean value) {
+    super(value);
 
 Review comment:
   This was to provide an 'of' static constructor with the given value type. I've made a test
to keep this consistent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message