nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
Date Mon, 25 Mar 2019 15:55:16 GMT
wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r268671682
 
 

 ##########
 File path: common/src/test/java/org/apache/nemo/common/UtilTest.java
 ##########
 @@ -16,27 +16,34 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.nemo.common.util;
+package org.apache.nemo.common;
 
 import static org.junit.Assert.assertEquals;
 
+import java.nio.file.Paths;
 import java.util.function.IntPredicate;
 
-import org.apache.nemo.common.Util;
+import org.junit.Assert;
 import org.junit.Test;
 
 public class UtilTest {
+  @Test
+  public void testRootPath() {
+    final String one = Util.recursivelyFindLicense(Paths.get(System.getProperty("user.dir")));
+    final String two = Util.recursivelyFindLicense(Paths.get(System.getProperty("user.dir")).getParent());
+    Assert.assertEquals(one, two);
+  }
 
-    @Test
-    public void testCheckEqualityOfIntPredicates() {
+  @Test
+  public void testCheckEqualityOfIntPredicates() {
 
-        IntPredicate firstPredicate = number -> number < 5;
-        IntPredicate secondPredicate = number -> number < 10;
-        assertEquals(true,
-                Util.checkEqualityOfIntPredicates(firstPredicate, secondPredicate, 4));
-        assertEquals(false,
-                Util.checkEqualityOfIntPredicates(firstPredicate, secondPredicate, 5));
-        assertEquals(false,
-                Util.checkEqualityOfIntPredicates(firstPredicate, secondPredicate, 7));
-    }
+    IntPredicate firstPredicate = number -> number < 5;
+    IntPredicate secondPredicate = number -> number < 10;
+    assertEquals(true,
+      Util.checkEqualityOfIntPredicates(firstPredicate, secondPredicate, 4));
+    assertEquals(false,
+      Util.checkEqualityOfIntPredicates(firstPredicate, secondPredicate, 5));
+    assertEquals(false,
+      Util.checkEqualityOfIntPredicates(firstPredicate, secondPredicate, 7));
+  }
 
 Review comment:
   Completely unnecessary change, which makes me spend time to check whether the code contents
is changed or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message