nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
Date Mon, 25 Mar 2019 15:55:16 GMT
wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r268661469
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/IRDAG.java
 ##########
 @@ -110,8 +109,16 @@ public boolean advanceDAGSnapshot(final BiFunction<IRDAG, IRDAG,
Boolean> checke
     return canAdvance;
   }
 
+  /**
+   * @return a IR DAG summary string, consisting of only the vertices generated from the
frontend.
+   */
   public String irDAGSummary() {
-    return "RV" + getRootVertices().size() + "_V" + getVertices().size() + "_E" + getVertices().stream()
+    return "rv" + this.getRootVertices().size()
+      + "_v" + this.getVertices().stream()
+      .filter(v -> !v.isUtilityVertex())  // Exclude utility vertices
+      .count()
+      + "_e" + this.getVertices().stream()
 
 Review comment:
   Why did you append `this.` to several get methods?
   Please remove them for consistency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message