nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
Date Thu, 21 Mar 2019 06:47:44 GMT
wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267637053
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/executionproperty/ExecutionProperty.java
 ##########
 @@ -42,6 +42,13 @@ public final T getValue() {
     return this.value;
   }
 
+  /**
+   * @return the class of the value type.
+   */
+  public final Class<? extends Serializable> getValueClass() {
 
 Review comment:
   You're right. It's been simple after all I'll get rid of the method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message