nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
Date Thu, 21 Mar 2019 05:14:52 GMT
wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267627259
 
 

 ##########
 File path: examples/beam/src/test/java/org/apache/nemo/examples/beam/WordCountITCase.java
 ##########
 @@ -127,4 +128,14 @@ public void testSpeculativeExecution() throws Exception {
       .addOptimizationPolicy(AggressiveSpeculativeCloningPolicyParallelismFive.class.getCanonicalName())
       .build());
   }
+
+  @Test (timeout = ExampleTestArgs.TIMEOUT)
+  public void testXGBoost() throws Exception {
+    JobLauncher.main(builder
+      .addResourceJson(executorResourceFileName)
+      .addJobId(WordCountITCase.class.getSimpleName() + "_xgboost")
+      .addMaxTaskAttempt(Integer.MAX_VALUE)
+      .addOptimizationPolicy(XGBoostPolicy.class.getCanonicalName())
+      .build());
+  }
 
 Review comment:
   What's the right output?
   Does it produce the same result every time?
   Then better to put the result as comment?
   
   It's just a suggestion. I know that all other apps of Nemo doesn't provide that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message