nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
Date Wed, 20 Mar 2019 22:45:13 GMT
taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267571228
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/IRDAG.java
 ##########
 @@ -110,8 +109,16 @@ public boolean advanceDAGSnapshot(final BiFunction<IRDAG, IRDAG,
Boolean> checke
     return canAdvance;
   }
 
+  /**
+   * @return a IR DAG summary string, consisting of only the original vertices generated
from the frontend.
+   */
   public String irDAGSummary() {
-    return "RV" + getRootVertices().size() + "_V" + getVertices().size() + "_E" + getVertices().stream()
+    return "rv" + this.getRootVertices().size()
+      + "_v" + this.getVertices().stream()
+      .filter(v -> !v.getClass().getPackage().getName().contains("vertex.utility"))  //
Exclude utility vertices
 
 Review comment:
   why do we exclude `vertex,utility` here? and is it good for the `DAG` to know which vertices
should be excluded? 
   Maybe we should need a utility function that filters specific vertices instead of modifying
this function. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message