nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
Date Wed, 20 Mar 2019 22:11:28 GMT
taegeonum commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267567250
 
 

 ##########
 File path: bin/run_nexmark.sh
 ##########
 @@ -21,4 +21,4 @@ VERSION=$(mvn -q \
   -Dexec.executable=echo -Dexec.args='${project.version}' \
   --non-recursive exec:exec)
 
-java -Dlog4j.configuration=file://`pwd`/log4j.properties -cp client/target/nemo-client-$VERSION-shaded.jar:`yarn
classpath`:examples/nexmark/target/nexmark-$VERSION-shaded.jar org.apache.nemo.client.JobLauncher
"$@"
+java -Dlog4j.configuration=file://`pwd`/log4j.properties -cp examples/nexmark/target/nexmark-${VERSION}-shaded.jar:`yarn
classpath` org.apache.nemo.client.JobLauncher "$@"
 
 Review comment:
   Could you please revert this change? 
   `run_beam.sh` includes client.jar and we don't need nemo-example jar file. You should include
the client jar file, instead of beam jar.  Also, nemo-360 is not related to this change. Please
create another PR for separate issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message