nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] wonook commented on a change in pull request #204: [NEMO-364] Upgrade Beam version
Date Wed, 20 Mar 2019 11:03:40 GMT
wonook commented on a change in pull request #204: [NEMO-364] Upgrade Beam version
URL: https://github.com/apache/incubator-nemo/pull/204#discussion_r267284669
 
 

 ##########
 File path: runtime/common/src/main/java/org/apache/nemo/runtime/common/metric/MetricUtils.java
 ##########
 @@ -294,23 +291,4 @@ private static String recursivelyFindLicense(final Path path) {
       throw new MetricException(e);
     }
   }
-
-  /**
-   * De-register Beam JDBC driver, which produces inconsistent results.
-   */
-  public static void deregisterBeamDriver() {
-    final String beamDriver = "org.apache.beam.sdk.extensions.sql.impl.JdbcDriver";
-    final Enumeration<Driver> drivers = DriverManager.getDrivers();
-    while (drivers.hasMoreElements()) {
-      final Driver d = drivers.nextElement();
-      if (d.getClass().getName().equals(beamDriver)) {
-        try {
-          DriverManager.deregisterDriver(d);
-        } catch (SQLException e) {
-          throw new MetricException(e);
-        }
-        break;
-      }
-    }
-  }
 
 Review comment:
   This was a patch for the bug on the Beam side, but it's been resolved after the 2.10.0
update. Here's the link: https://beam.apache.org/blog/2019/02/15/beam-2.10.0.html
   Please refer to the line that says: SQL: JDBC driver no longer breaks interactions with
other JDBC sources

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message