nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] alapha23 commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and waitUntilFinish methods
Date Fri, 15 Mar 2019 03:41:49 GMT
alapha23 commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and
waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r265841301
 
 

 ##########
 File path: client/src/main/java/org/apache/nemo/client/ClientEndpoint.java
 ##########
 @@ -164,7 +164,8 @@ public final Enum waitUntilJobFinish(final long timeout,
         return stateTranslator.translateState(driverEndpoint.get().
             waitUntilFinish(timeout - unit.convert(consumedTime, TimeUnit.NANOSECONDS), unit));
       } else {
-        return PlanState.State.READY;
+        // This default value needs double checking.
+        return stateTranslator.translateState(PlanState.State.READY);
 
 Review comment:
   @wonook  
   @taegeonum and me think that `ClientEndpoint` and `DriverEndpoint` are not used anymore.
We presume these are just legacy code we forgot to remove. 
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message