nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] apeinot commented on issue #196: [NEMO-253] Refactor getInternal(Main/Additional)OutputMap in TaskExecutor
Date Wed, 27 Feb 2019 07:58:14 GMT
apeinot commented on issue #196: [NEMO-253] Refactor getInternal(Main/Additional)OutputMap
in TaskExecutor
URL: https://github.com/apache/incubator-nemo/pull/196#issuecomment-467761330
 
 
   Hi @johnyangk ! Thanks for your advice. I think your proposed change is relevant and I
have addressed it in my last commit. 
   There is only one difference. Because of the checkstyle configuration, I had to change
MAIN_OUTPUT_TAG to mainOutputTag and made this variable private instead of public (I added
the corresponding getter)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message