nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] johnyangk commented on a change in pull request #193: [NEMO-338] SkewSamplingPass
Date Wed, 20 Feb 2019 07:27:16 GMT
johnyangk commented on a change in pull request #193: [NEMO-338] SkewSamplingPass
URL: https://github.com/apache/incubator-nemo/pull/193#discussion_r258350397
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/IRDAG.java
 ##########
 @@ -151,73 +176,153 @@ public void insert(final StreamVertex streamVertex, final IREdge edgeToStreamize
    *        shuffleEdge - messageAggregatorVertex - broadcastEdge - dst
    * (the "Before" relationships are unmodified)
    *
+   * This preserves semantics as the results of the inserted message vertices are never consumed
by the original IRDAG.
+   *
    * @param messageBarrierVertex to insert.
    * @param messageAggregatorVertex to insert.
    * @param mbvOutputEncoder to use.
    * @param mbvOutputDecoder to use.
    * @param edgesToGetStatisticsOf to examine.
+   * @param edgesToOptimize to optimize.
    */
   public void insert(final MessageBarrierVertex messageBarrierVertex,
 
 Review comment:
   Created a JIRA for this: https://issues.apache.org/jira/browse/NEMO-341

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message