nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] wynot12 commented on a change in pull request #192: [NEMO-335] DB for storing metrics
Date Wed, 13 Feb 2019 10:33:14 GMT
wynot12 commented on a change in pull request #192: [NEMO-335] DB for storing metrics

 File path: runtime/master/src/main/java/org/apache/nemo/runtime/master/metric/
 @@ -206,17 +210,106 @@ public synchronized String dumpAllMetricToJson() throws IOException
    * @param filePath path to dump JSON.
   public void dumpAllMetricToFile(final String filePath) {
-    try {
+    try (final BufferedWriter writer = new BufferedWriter(new FileWriter(filePath))) {
       final String jsonDump = dumpAllMetricToJson();
-      final BufferedWriter writer = new BufferedWriter(new FileWriter(filePath));
-      writer.close();
     } catch (final IOException e) {
-      throw new RuntimeException(e);
+      throw new MetricException(e);
+  /**
+   * Save the job metrics for the optimization to the DB, in the form of LibSVM, to SQLite.
+   * The metrics are as follows: the JCT (duration), and the IR DAG execution properties.
+   */
+  public void saveOptimizationMetricsToSQLite() {
 Review comment:
   I don't think the method name is proper.
   The point is that it saves optimization metrics to local db.
   How about to rename it to `saveMetricsToLocal()`?
   And.. it could be private method..?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message