nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] wonook commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass
Date Fri, 01 Feb 2019 03:23:48 GMT
wonook commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass
URL: https://github.com/apache/incubator-nemo/pull/191#discussion_r252922957
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/MinParallelismProperty.java
 ##########
 @@ -23,13 +23,13 @@
 /**
  * Parallelism ExecutionProperty.
  */
-public final class ParallelismProperty extends VertexExecutionProperty<Integer> {
+public final class MinParallelismProperty extends VertexExecutionProperty<Integer>
{
 
 Review comment:
   Do you think that this property would be meaningful even when it doesn't show the accurate
values of the parallelism of each vertex? Why not update the value of the `ParallelismProperty`
instead when the cases described above occur?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message