nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] wonook commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass
Date Fri, 01 Feb 2019 03:21:32 GMT
wonook commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass
URL: https://github.com/apache/incubator-nemo/pull/191#discussion_r252922711
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/MinParallelismProperty.java
 ##########
 @@ -21,15 +21,20 @@
 import org.apache.nemo.common.ir.executionproperty.VertexExecutionProperty;
 
 /**
- * Parallelism ExecutionProperty.
+ * This property decides the minimum number of parallel tasks to use for executing the corresponding
IRVertex.
+ *
+ * The actual number of tasks used in the execution can be greater due the following reasons.
+ * - A larger number of parallelism of a parent IRVertex connected with an one-to-one IREdge.
 
 Review comment:
   Is this possible? doesn't it check whether or not it has the same parallelism before connecting
with a 1-1 edge?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message