nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] wonook commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass
Date Fri, 01 Feb 2019 03:19:22 GMT
wonook commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass
URL: https://github.com/apache/incubator-nemo/pull/191#discussion_r252922464
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/vertex/system/SystemIRVertex.java
 ##########
 @@ -16,14 +16,20 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.nemo.common;
+package org.apache.nemo.common.ir.vertex.system;
 
-import java.io.Serializable;
+import org.apache.nemo.common.ir.vertex.OperatorVertex;
+import org.apache.nemo.common.ir.vertex.transform.Transform;
 
 /**
- * A serializable metric factory.
- *
- * @param <T> metric type.
+ * System vertices can be dynamically inserted into an IRDAG to optimize execution.
  */
-public interface MetricFactory<T> extends Serializable {
+abstract class SystemIRVertex extends OperatorVertex {
 
 Review comment:
   What's a `system vertex`? Is this a commonly used term?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message