From notifications-return-66-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Wed Jan 30 08:28:31 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C6913180652 for ; Wed, 30 Jan 2019 09:28:29 +0100 (CET) Received: (qmail 96620 invoked by uid 500); 30 Jan 2019 08:28:28 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 96610 invoked by uid 99); 30 Jan 2019 08:28:28 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jan 2019 08:28:28 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] jeongyooneo commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass Message-ID: <154883690826.20837.4634157301778401786.gitbox@gitbox.apache.org> Date: Wed, 30 Jan 2019 08:28:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jeongyooneo commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass URL: https://github.com/apache/incubator-nemo/pull/191#discussion_r252131875 ########## File path: common/src/main/java/org/apache/nemo/common/ir/vertex/transform/StreamTransform.java ########## @@ -28,14 +28,14 @@ * This transform can be used for merging input data into the {@link OutputCollector}. * @param input/output type. */ -public final class RelayTransform implements Transform { +public final class StreamTransform implements Transform { Review comment: `StreamTransform` intuitively sounds like transform used in stream operation(other than batch). How about `ShuffleDataStreamTransform` or something like that to keep the nuance of 'relaying promptly'? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services