nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jeongyooneo commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass
Date Wed, 30 Jan 2019 08:28:28 GMT
jeongyooneo commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass
URL: https://github.com/apache/incubator-nemo/pull/191#discussion_r252130067
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/vertex/system/MessageAggregatorVertex.java
 ##########
 @@ -16,28 +16,26 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.nemo.common;
+package org.apache.nemo.common.ir.vertex.system;
 
 Review comment:
   How about having `basic`, `optimization`(or `specialized`?) 2-package structure?
   - `optimization` package for `MessageAggregatorVertex` and `MessageBarrierVertex`, as they're
used in DAG optimization
   - `basic` package for `StreamVertex`, `OperatorVertex`, ... etc other than `IRVertex`,
since they all extend IRVertex

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message