nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jeongyooneo commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass
Date Wed, 30 Jan 2019 08:28:28 GMT
jeongyooneo commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass
URL: https://github.com/apache/incubator-nemo/pull/191#discussion_r252126880
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/edge/executionproperty/PartitionerProperty.java
 ##########
 @@ -18,38 +18,62 @@
  */
 package org.apache.nemo.common.ir.edge.executionproperty;
 
+import org.apache.nemo.common.Pair;
 import org.apache.nemo.common.ir.executionproperty.EdgeExecutionProperty;
 
 /**
  * Partitioner ExecutionProperty.
  */
-public final class PartitionerProperty extends EdgeExecutionProperty<PartitionerProperty.Value>
{
+public final class PartitionerProperty
+  extends EdgeExecutionProperty<Pair<PartitionerProperty.Type, Integer>> {
+  public static final int AUTO_NUMBER_OF_PARTITIONS = 0;
+
   /**
    * Constructor.
    *
    * @param value value of the execution property.
    */
-  private PartitionerProperty(final Value value) {
+  private PartitionerProperty(final Pair<Type, Integer> value) {
     super(value);
   }
 
   /**
-   * Static method exposing the constructor.
-   *
-   * @param value value of the new execution property.
-   * @return the newly created execution property.
+   * Use the automatic number of partitions.
 
 Review comment:
   Ditto.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message