nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] wonook commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and waitUntilFinish methods
Date Tue, 22 Jan 2019 14:51:28 GMT
wonook commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and waitUntilFinish
methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r249810809
 
 

 ##########
 File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/NemoPipelineResult.java
 ##########
 @@ -49,10 +60,12 @@ public State cancel() throws IOException {
 
   @Override
   public State waitUntilFinish(final Duration duration) {
-    throw new UnsupportedOperationException();
-    // TODO #208: NemoPipelineResult#waitUntilFinish hangs
-    // Previous code that hangs the job:
-    // return (State) super.waitUntilJobFinish(duration.getMillis(), TimeUnit.MILLISECONDS);
+    try {
+      this.jobDone.await();
+    } catch (final InterruptedException e) {
+      throw new RuntimeException(e);
+    }
+    return (State) super.waitUntilJobFinish(duration.getMillis(), TimeUnit.MILLISECONDS);
 
 Review comment:
   Does it actually get called after the job finishes? I was unsure, because I experienced
failing integration tests when using this by itself.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message