From dev-return-1364-archive-asf-public=cust-asf.ponee.io@nemo.apache.org  Tue Oct  9 13:46:15 2018
Return-Path: <dev-return-1364-archive-asf-public=cust-asf.ponee.io@nemo.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id CFD4F1807A5
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  9 Oct 2018 13:46:11 +0200 (CEST)
Received: (qmail 42084 invoked by uid 500); 9 Oct 2018 11:46:10 -0000
Mailing-List: contact dev-help@nemo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@nemo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@nemo.apache.org>
List-Post: <mailto:dev@nemo.apache.org>
List-Id: <dev.nemo.apache.org>
Reply-To: dev@nemo.apache.org
Delivered-To: mailing list dev@nemo.apache.org
Received: (qmail 41623 invoked by uid 99); 9 Oct 2018 11:46:10 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2018 11:46:10 +0000
From: GitBox <git@apache.org>
To: dev@nemo.apache.org
Subject: [GitHub] johnyangk commented on a change in pull request #122: [NEMO-213]
 Use Beam's DoFnRunners to execute DoFn
Message-ID: <153908557015.3039.2440995603892245040.gitbox@gitbox.apache.org>
Date: Tue, 09 Oct 2018 11:46:10 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

johnyangk commented on a change in pull request #122: [NEMO-213] Use Beam's DoFnRunners to execute DoFn
URL: https://github.com/apache/incubator-nemo/pull/122#discussion_r223660368
 
 

 ##########
 File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyTransform.java
 ##########
 @@ -40,23 +41,27 @@ public GroupByKeyTransform() {
   }
 
   @Override
-  public void prepare(final Context context, final OutputCollector<KV<Object, List>> oc) {
+  public void prepare(final Context context, final OutputCollector<WindowedValue<KV<Object, List>>> oc) {
     this.outputCollector = oc;
   }
 
   @Override
   public void onData(final I element) {
-    final KV kv = (KV) element;
+    // TODO #: support window in group by key
+    final WindowedValue<KV> windowedValue = (WindowedValue<KV>) element;
+    final KV kv = windowedValue.getValue();
     keyToValues.putIfAbsent(kv.getKey(), new ArrayList());
     keyToValues.get(kv.getKey()).add(kv.getValue());
   }
 
   @Override
   public void close() {
+    // TODO #: support window in group by key
 
 Review comment:
   Ditto.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services