nemo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] johnyangk commented on a change in pull request #122: [NEMO-213] Use Beam's DoFnRunners to execute DoFn
Date Tue, 09 Oct 2018 11:46:09 GMT
johnyangk commented on a change in pull request #122: [NEMO-213] Use Beam's DoFnRunners to
execute DoFn
URL: https://github.com/apache/incubator-nemo/pull/122#discussion_r223655193
 
 

 ##########
 File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/PipelineTranslator.java
 ##########
 @@ -107,7 +120,7 @@ private PipelineTranslator() {
   private static void boundedReadTranslator(final TranslationContext ctx,
                                             final PrimitiveTransformVertex transformVertex,
                                             final Read.Bounded<?> transform) {
-    final IRVertex vertex = new BeamBoundedSourceVertex<>(transform.getSource());
+    final IRVertex vertex = new BeamBoundedWindowSourceVertex<>(transform.getSource());
 
 Review comment:
   `BeamBoundedSourceVertex` seems to be an unused class now.
   
   How about 
   (1) removing the current `BeamBoundedSourceVertex`, and 
   (2) renaming `BeamBoundedWindowSourceVertex` to `BeamBoundedSourceVertex`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message