From commits-return-255-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Thu Jul 19 11:31:25 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CD52318067A for ; Thu, 19 Jul 2018 11:31:24 +0200 (CEST) Received: (qmail 74315 invoked by uid 500); 19 Jul 2018 09:31:24 -0000 Mailing-List: contact commits-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list commits@nemo.apache.org Received: (qmail 74306 invoked by uid 99); 19 Jul 2018 09:31:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jul 2018 09:31:23 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 6CEFB820E8; Thu, 19 Jul 2018 09:31:23 +0000 (UTC) Date: Thu, 19 Jul 2018 09:31:23 +0000 To: "commits@nemo.apache.org" Subject: [incubator-nemo] branch master updated: [NEMO-165] Bug when a task reads from multiple parent tasks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <153199268338.20044.17036177524327791250@gitbox.apache.org> From: jeongyoon@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-nemo X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 3e9b400395430cf950a08d247f3c24f0c93e373e X-Git-Newrev: 1a39efabb248fc9d195fb55e1a79e645d1df3714 X-Git-Rev: 1a39efabb248fc9d195fb55e1a79e645d1df3714 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. jeongyoon pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nemo.git The following commit(s) were added to refs/heads/master by this push: new 1a39efa [NEMO-165] Bug when a task reads from multiple parent tasks 1a39efa is described below commit 1a39efabb248fc9d195fb55e1a79e645d1df3714 Author: John Yang AuthorDate: Thu Jul 19 18:31:21 2018 +0900 [NEMO-165] Bug when a task reads from multiple parent tasks JIRA: NEMO-165: Bug when a task reads from multiple parent tasks Major changes: * In TaskExecutor#handleDataFetchers, initialize "int finishedFetcherIndex" in each looping, and not outside the loop. Minor changes to note: N/A Tests for the changes: N/A Other comments: N/A resolves NEMO-165 --- .../src/main/java/edu/snu/nemo/runtime/executor/task/TaskExecutor.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/task/TaskExecutor.java b/runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/task/TaskExecutor.java index bfcd040..7520730 100644 --- a/runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/task/TaskExecutor.java +++ b/runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/task/TaskExecutor.java @@ -350,8 +350,9 @@ public final class TaskExecutor { */ private boolean handleDataFetchers(final List fetchers) { final List availableFetchers = new ArrayList<>(fetchers); - int finishedFetcherIndex = NONE_FINISHED; while (!availableFetchers.isEmpty()) { // empty means we've consumed all task-external input data + // For this looping of available fetchers. + int finishedFetcherIndex = NONE_FINISHED; for (int i = 0; i < availableFetchers.size(); i++) { final DataFetcher dataFetcher = fetchers.get(i); final Object element;