nemo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wy...@apache.org
Subject [incubator-nemo] 03/05: Fix style error
Date Tue, 03 Jul 2018 08:30:15 GMT
This is an automated email from the ASF dual-hosted git repository.

wylee pushed a commit to branch 106-move-compiler-test
in repository https://gitbox.apache.org/repos/asf/incubator-nemo.git

commit 6999a4e2c163c440cce62e37ea8acbd6a72ce200
Author: WooYeon <wylee.xyzi@gmail.com>
AuthorDate: Tue Jul 3 17:00:23 2018 +0900

    Fix style error
---
 .../java/edu/snu/nemo/compiler/CompilerTestUtil.java    | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/compiler/test/src/main/java/edu/snu/nemo/compiler/CompilerTestUtil.java b/compiler/test/src/main/java/edu/snu/nemo/compiler/CompilerTestUtil.java
index a8e7cc9..eb3f2cc 100644
--- a/compiler/test/src/main/java/edu/snu/nemo/compiler/CompilerTestUtil.java
+++ b/compiler/test/src/main/java/edu/snu/nemo/compiler/CompilerTestUtil.java
@@ -33,7 +33,12 @@ import java.lang.reflect.Method;
  * Utility methods for tests.
  */
 public final class CompilerTestUtil {
-  private static final String rootDir = System.getProperty("user.dir");
+  private static final String ROOT_DIR = System.getProperty("user.dir");
+
+  // Utility classes should not have a public or default constructor
+  private CompilerTestUtil() {
+
+  }
 
   private static DAG<IRVertex, IREdge> compileDAG(final String[] args) throws Exception
{
     final String userMainClassName;
@@ -60,8 +65,8 @@ public final class CompilerTestUtil {
   }
 
   public static DAG<IRVertex, IREdge> compileWordCountDAG() throws Exception {
-    final String input = rootDir + "/../../examples/resources/sample_input_wordcount";
-    final String output = rootDir + "/../../examples/resources/sample_output";
+    final String input = ROOT_DIR + "/../../examples/resources/sample_input_wordcount";
+    final String output = ROOT_DIR + "/../../examples/resources/sample_output";
     final String main = "edu.snu.nemo.examples.beam.WordCount";
 
     final ArgBuilder mrArgBuilder = new ArgBuilder()
@@ -72,7 +77,7 @@ public final class CompilerTestUtil {
   }
 
   public static DAG<IRVertex, IREdge> compileALSDAG() throws Exception {
-    final String input = rootDir + "/../../examples/resources/sample_input_als";
+    final String input = ROOT_DIR + "/../../examples/resources/sample_input_als";
     final String numFeatures = "10";
     final String numIteration = "3";
     final String main = "edu.snu.nemo.examples.beam.AlternatingLeastSquare";
@@ -85,7 +90,7 @@ public final class CompilerTestUtil {
   }
 
   public static DAG<IRVertex, IREdge> compileALSInefficientDAG() throws Exception {
-    final String input = rootDir + "/../../examples/resources/sample_input_als";
+    final String input = ROOT_DIR + "/../../examples/resources/sample_input_als";
     final String numFeatures = "10";
     final String numIteration = "3";
     final String main = "edu.snu.nemo.examples.beam.AlternatingLeastSquareInefficient";
@@ -98,7 +103,7 @@ public final class CompilerTestUtil {
   }
 
   public static DAG<IRVertex, IREdge> compileMLRDAG() throws Exception {
-    final String input = rootDir + "/../../examples/resources/sample_input_mlr";
+    final String input = ROOT_DIR + "/../../examples/resources/sample_input_mlr";
     final String numFeatures = "100";
     final String numClasses = "5";
     final String numIteration = "3";


Mime
View raw message