mynewt-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MYNEWT-879) os_sched_sleep and os_sched_insert could insert into sleep or run list incorrectly
Date Thu, 04 Jan 2018 21:18:00 GMT

    [ https://issues.apache.org/jira/browse/MYNEWT-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312044#comment-16312044
] 

ASF subversion and git services commented on MYNEWT-879:
--------------------------------------------------------

Commit 8a36be7ceb4ca67821574c2efa4a62a5334a334c in mynewt-core's branch refs/heads/master
from [~wes3]
[ https://gitbox.apache.org/repos/asf?p=mynewt-core.git;h=8a36be7 ]

Revert "MYNEWT-879: fixup incorrect comment."

This reverts commit 288f593446c8b962671ee81848afd6f78b953c8f.


> os_sched_sleep and os_sched_insert could insert into sleep or run list incorrectly
> ----------------------------------------------------------------------------------
>
>                 Key: MYNEWT-879
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-879
>             Project: Mynewt
>          Issue Type: Bug
>      Security Level: Public(Viewable by anyone) 
>          Components: OS
>    Affects Versions: v1_3_0_rel
>            Reporter: William San Filippo
>            Assignee: William San Filippo
>
> The queue.h macros TAILQ_INSERT_TAIL will not set the first element in the head of the
list if the list is empty. This is by design. Unfortunately, the OS code does not check in
two places when inserting into the sleep list (os_sched_sleep) or the run list (os_sched_insert)
if the list is empty. The code has to specifically check if the list is empty, and if so,
call TAILQ_INSERT_HEAD (rather than insert tail).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message