From commits-return-17565-archive-asf-public=cust-asf.ponee.io@mynewt.apache.org Tue Apr 3 10:00:00 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B0E55180675 for ; Tue, 3 Apr 2018 09:59:59 +0200 (CEST) Received: (qmail 24010 invoked by uid 500); 3 Apr 2018 07:59:58 -0000 Mailing-List: contact commits-help@mynewt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mynewt.apache.org Delivered-To: mailing list commits@mynewt.apache.org Received: (qmail 23990 invoked by uid 99); 3 Apr 2018 07:59:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Apr 2018 07:59:58 +0000 From: GitBox To: commits@mynewt.apache.org Subject: [GitHub] mkiiskila commented on a change in pull request #934: util/parse - Additional parsing functions. Message-ID: <152274239785.26823.5365321736729372468.gitbox@gitbox.apache.org> Date: Tue, 03 Apr 2018 07:59:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mkiiskila commented on a change in pull request #934: util/parse - Additional parsing functions. URL: https://github.com/apache/mynewt-core/pull/934#discussion_r178735606 ########## File path: net/ip/mn_socket/include/mn_socket/mn_socket.h ########## @@ -187,6 +187,9 @@ int mn_close(struct mn_socket *); /* * Address conversion */ + +#define MN_INET6_MAX_LEN (39) /* Does not include terminating \0. */ Review comment: To match the naming of the other items should use the following instead. Also note the size. And if adding this one, probably should add the MN_INET_ADDRSTRLEN there as well :) #define MN_INET6_ADDRSTRLEN 46 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services